feat: excludes emoji from a11y container with alt caption #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub allows emoji content in descriptions. As of now, the extension will add the caption container to this emoji, which makes reading of flow content a bit awkward.
I'm proposing that we bypass this specifically for emojis, although I do know that emoji management inside text is an accessibility concern. Maybe there's some other way to surface this, however?
Examples:
in our text descriptions. For some reason, it seems to be handled differently from other emoji like the 100 (💯) and thumbs up (👍).
Sometimes we render an octocat