Fix heading position styles to prevent overlap and extract styles into CSS file #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the heading position CSS to not use absolute positioning for aligning the appended heading level text. The reason is because if the heading text is very long, the appended text can end up overlapping. Instead, we use table cell CSS to position the appended heading level to right of end of line (Reference: https://stackoverflow.com/a/17175726).
We also extract the styles into a CSS file to allow for easier customization. Applying styles via classname instead of through inline styling also will make it easier to debug when there are issues. We update README accordingly.