MBL- 2489 Late pledges Regression for Android 3.32.0 #2344
Merged
+75
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2344 +/- ##
=========================================
Coverage 66.51% 66.51%
- Complexity 2271 2272 +1
=========================================
Files 367 367
Lines 25785 25803 +18
Branches 3861 3866 +5
=========================================
+ Hits 17151 17164 +13
- Misses 6657 6660 +3
- Partials 1977 1979 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
just need to fix the tets that are not working now |
Arkariang
approved these changes
Jun 11, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Refactored the onContinueClicked method in CheckoutFlowViewModel to support a simplified use case where only a continueCallback is needed. This is now used in ProjectPageActivity when login flow is already guaranteed to be completed.
🤔 Why
The original onContinueClicked required both logInCallback and continueCallback, even in cases where the user is already logged in and the login check was redundant. This change adds a simpler, cleaner path for flows where login gating is handled earlier in the UI flow, improving readability and responsibility separation.
🛠 How
Implemented the onContinueClicked(continueCallback: () -> Unit) method to:
👀 See
latepledgefix.webm
📋 QA
2. Do the checkout flow
3. Select a reward and proceed to add addons.
4. Addons selection should then send you the final checkout step
5. Verify pledge submission still works correctly.
Story 📖
MBL- 2489 Late pledges Regression for Android 3.32.0