MBL-2842: Only show 'manage pledge' menu if backing the project #2435
Conversation
There was a problem hiding this comment.
I know is covered by tests on ProjectPageViewModelTest, but might be worth it creating specific tests for this isolated piece if possible to avoid any similar bugs in the future. No need to do it now! perfectly ok with a separated ticket
There was a problem hiding this comment.
No you're right, I was going to add a test I promise XD
There was a problem hiding this comment.
I went ahead and commented with it still on draft, no need to apologize! XD, will be more patient promised! 👍
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2435 +/- ##
=========================================
Coverage 64.64% 64.65%
- Complexity 2390 2392 +2
=========================================
Files 376 376
Lines 28453 28453
Branches 4119 4121 +2
=========================================
+ Hits 18393 18395 +2
Misses 7800 7800
+ Partials 2260 2258 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
(cherry picked from commit 172be4b)
📲 What
Show 'manage pledge' menu items only when a user is a backer of a Project.
🤔 Why
Users can only manage the Pledge of a Project they are backing.
🛠 How
Check
Project.isBacking()when creating theManagePledgeMenuOptionsobject used to show/hide items in the 'manage pledge' menu.👀 See
As a non-Backer
📋 QA
(1) Visit the rewards carousel for a Project that you are not backing and confirm that the toolbar menu is hidden.
(2) Visit the Manage Pledge screen for Project that you are backing, and ensure that the proper menu items are visible and accessible.
Story 📖
[MBL-2842] Manage Pledge menu items visible when not backing - Jira