Thanks to visit codestin.com
Credit goes to github.com

Skip to content

NT- 1290: Add-ons UI in BackingFragment #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 17, 2020
Merged

NT- 1290: Add-ons UI in BackingFragment #900

merged 12 commits into from
Jun 17, 2020
+694 −96

Conversation

@Arkariang
Copy link
Contributor

📲 What

  • Now in backing fragment you can see your selected reward plus Add-ons

🤔 Why

  • The website already allows you to pledge selecting add-ons, now as mobile user if you pledge to some project selecting add-ons as well you will see those reflected in the app.

🛠 How

New shared UI for rewards and Add-ons in backing fragment.

👀 See

  • Reward with Add-Ons
    Screen Shot 2020-06-15 at 8 23 06 AM

📋 QA

  • If you wanna QA this and do not have project with add-ons you can try this:
    Substitute the code in the function com.kickstarter.ui.adapters.RewardAndAddOnsAdapter#populateDataForAddOns for the code below:
        val rw2 = RewardFactory.endingSoon().toBuilder().isAddOn(true).quantity(4).build()
        val rw3 = RewardFactory.itemized().toBuilder().isAddOn(true).quantity(1).build()
        val rw4 = RewardFactory.multipleLocationShipping().toBuilder().isAddOn(true).quantity(10).build()
        val projectAndRw2 = listOf(Pair(project, rw1),Pair(project,rw2),Pair(project, rw3), Pair(project,rw4))
        rewardsAndAddOnsAdapter.populateDataForAddOns(projectAndRw2)

Story 📖

Add- Ons UI

@Arkariang Arkariang requested a review from JadeByfield89 June 15, 2020 15:28
JadeByfield89
JadeByfield89 approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@JadeByfield89 JadeByfield89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the walkthrough of this PR. Nice work!

@Arkariang Arkariang merged commit 21ecb72 into feature/NT-1141-add-ons Jun 17, 2020
@Arkariang Arkariang deleted the imartin/NT-1290-AddOns-UI branch June 17, 2020 15:00
JadeByfield89 pushed a commit that referenced this pull request Jul 22, 2020
@Arkariang
NT- 1290: Add-ons UI in BackingFragment (#900)
c8b2fc6 
- Loading the new UI in BackingFragment for Rewards & Add - ons
- Bug when no location
Arkariang added a commit that referenced this pull request Oct 15, 2020
@Arkariang @JadeByfield89
@leighdouglas @jgsamudio
NT-1382: AddOns (#1017)
e5eb628 
* NT-1231 Creator Perspective query + View your pledge updated (#895)
* NT-1141: Refactor existing queries (#897)
* NT-1294: RecyclerView structure for reward & Add-ons (#896)
* NT-1222:Retrieve Add-ons data from Graph (#899)
* NT- 1290: Add-ons UI in BackingFragment (#900)
* NT-1171: Manage Pledge View Backing Info updates (#902)
* NT-1290: Add-ons UI(with real data from staging) (#905)
* NT-1326: Pledge header ui just for rewards (#906)
* NT-1327: Header animation (#911)
* NT-1171: (Fixed) Manage Pledge View Backing Info updates (#912)
* NT-1326 : Add total amount back to the header (#914)
* NT-1326: Reward Title going two lines (#918)
* NT-1345: Bonus support validation fixes (#917)
* NT-1345: Bonus support validation fixes (#917)
* NT-1383: New add-ons screen (#923)
* NT-1384: Add-ons list (#925)
* NT-1384- AddOns query (#927)
* NT-1411: Creator crash fixed (#929)
* NT-1385: Add Ons Card UI  (#930)
* NT-1386: Stepper UI on Add-On card (#937)
* NT-1422 && NT-1402 && NT-1383 && NT-1385 && NT-1382: Fix rejected (#946)
* NT-1386:Rejected fix (#947)
* NT-1381: Pledge header design polish (#948)
* NT-1426: Android Manage Pledge View Design Polish (#949)
* NT-1380 Bonus support design polish (#950)
* NT-1344: Updated checkout with new mutation  (#951)
* NT-1344: Updated checkout with new mutation 
* NT- 1462&& NT-1463: UpdateBacking Mutation  (#952)
* NT-1462:Update pledge flow (#954)
* NT-1445: Selected Reward Tag  (#955)
* NT-1390: Previously selected reward logic (#956)
* NT-1440:Display Empty State when add-ons unavailable (#961)
* NT-1453:Maximum pledge string updates (#962)
* NT-1460:Update add ons selection (#959)
* NT-1417: Show a native alert during Edit Reward if changes would remove add ons (#965)
* NT-1387: Fix Add-Ons Available tag for Digital Reward (#970)
* NT-1387: Fix - Select AddOns for digital reward (#971)
* [NT-1453][NT-1344][NT-1399][NT-1509]: Fix Pledge with Digital addOns  (#974)
* [NT-1417][NT-1510]:Fix change reward flow (#975)
* NT-1442: Android Display an error state if add-ons fail to load (#980)
* NT-1516: Update the Bonus Support Base Amount (#981)
* NT-1534: Sold-out add-ons (#983)
* [NT-1453] Bonus Support Max Pledge String Fix (#987)
* NT-1442: Hide shipping selector on network error (#986)
* NT-1471 | NT-1539 - Prevent Add-ons Alert & Add Pledge Label (#991)
* NT-1549 : Choose another reward flow (#993)
* NT-1539: Unprompted Edit Rewards Alert (#994)
* NT-1541: Updated Add-ons Quantity Not Updated (#995)
* NT-1534: Android Sold-out add-ons fix (#996)
* NT-1534: Modify previously backed AddOns if unavailable (#1005)
* NT-606: FIX Display a string indicating backing state for creators on View/Manage Pledge screen 
* NT-1585:Reward with starting time restriction not started yet. (#1009)
* https://kickstarter.atlassian.net/browse/NT-1587 (#1011)
* NT- 1591:Blanck screen edit reward flow (#1012)
* NT-1531: Android Refactor RewardUtils Java to Kotlin (#1008)
* NT-1587: Improve performance (#1013)
* NT-1587: Query with filtering for shippingRules (#1015)

Co-authored-by: Jade Byfield <[email protected]>
Co-authored-by: Jade Byfield <[email protected]>
Co-authored-by: leighdouglas <[email protected]>
Co-authored-by: jgsamudio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JadeByfield89 JadeByfield89 JadeByfield89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Arkariang @JadeByfield89