Revert "checks if the connection is still valid before executing, rec… #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnects if needed" the changes are not thread safe This reverts commit e562c28.
Contributor
Author
|
Is reverting the version file safe here? Basically just rolling back to before 2.6.4 was ever created |
Member
I believe so but if we release another version we would need to skip 2.6.4, which we should revoke. |
talaris
approved these changes
Oct 13, 2023
amancevice
reviewed
Oct 13, 2023
| services: | ||
| mysql: | ||
| image: mysql:8.0 | ||
| image: mysql:5.7 |
Contributor
There was a problem hiding this comment.
do you want to revert this?
Contributor
Author
There was a problem hiding this comment.
I think so, just for simplicity sake so that the tagged 2.6.3 version remains completely unchanged. It doesn't have any real effect anyways.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…onnects if needed"
This reverts commit e562c28.
the
verify!method is not threadsafe and can lead to connection errors when a connection is refreshed in another thread.