Login improvements: Improve domain inference and inaccessible domain error message #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if RAWeb is hosted on a domain-joined device that is having trouble connecting to the domain controller (e.g., a work laptop that was brought home and is not connected to the employer's VPN), the login page infers the login domain as the machine name. This leads to a confusing message about an unknown username or password.
With this change, RAWeb attempts to read the domain from the registry before falling back to the machine name. For a domain-joined device that cannot reach the domain, the error message will now correctly state that authentication failed because the domain could not be reached.
To clairify that the machine hosting RAWeb must be able to reach the domain, the unfound domain error message has also been changed to "Could not sign in because the specified domain is not available. Please make sure the RAWeb server is connected to your domain's network and try again."
Resolves #83.
Install
Run as an administrator in PowerShell to install this branch:
Checklist
Tested on: