-
Notifications
You must be signed in to change notification settings - Fork 86
Limit access to RAWeb files by other IIS applications and move all user-provided or modifiable files to the App_Data folder #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jackbuehner
merged 15 commits into
kimmknight:master
from
jackbuehner:restricted-permissions
Jul 20, 2025
Merged
Limit access to RAWeb files by other IIS applications and move all user-provided or modifiable files to the App_Data folder #98
jackbuehner
merged 15 commits into
kimmknight:master
from
jackbuehner:restricted-permissions
Jul 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfig` This change means that we can only grant access to app data rather than all of the app's files, including Web.config. Long term, it is better to remove write access to non-user-provided files so that a vulnerability in the raweb code does not allow code that executes on the server to be modified into something malicious.
It is much faster than `UserPrincipal.FindByIdentity`. Using the application pool identity instead of IUSR is an example case that cause `UserPrincipal.FindByIdentity` to slow down.
… pool and authenticate with the application pool's identity; and restict filesystem access for RAWeb files to SYSTEM, Administrators, and the raweb application pool
…e App_Data during reinstall/upgrade
…ettings.config on upgrade via setup.ps1
2765558 to
fb625e5
Compare
Otherwise, authentication does not work for non-administrators.
…eader.CanAccessPath`
…tory during reinstall/upgrade Switching to robocopy and including security permissions and timestamps causes everything about the folder and its subfolders to by preserved.
…ted user's principal
…ing Web.config appSettings to App_Data/appSettings.config
…s preserved when upgrading or reinstalling RAWeb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
enhancement
New feature or request
security
Related to a security issue or improvement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, any IIS application has read and write access to RAWeb files because we grant read and write access to the IIS_IUSRS account. We grant write access because we need to modify the app settings in Web.config.
To improve security, we now:
As part of this change, app settings from Web.config and the resources and multiuser-resources folders are now stored in the App_Data folder. Security permissions for resources are now preserved when upgrading or reinstalling RAWeb. The setup script handles the migration of the app settings and resources.
Resolves #97
Resolves #96
Install
Run as an administrator in PowerShell to install this branch:
Checklist
Tested on:
Tested scenarios: