Always use the default wallpaper instead of the default icon for desktops in the resource editor dialog #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… desktops in the resource editor dialog Fixes kimmknight#179.
✅ Deployment successfulPreview URL: https://raweb.app/deploy-preview/pr-181/
Local install
Run as an administrator in PowerShell to install this branch: iwr -UseBasicParsing install.raweb.app/preview/jackbuehner/179=fix | iex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, managed file resources that represent desktops will always show the desktop wallpaper as their default image.
The check for whether the resource indicated a desktop resource vs a RemoteApp resource was not reactive, so if the data was not available as soon as the edit dialog was created, it would use the default case (RemoteApp).
Fixes #179.