validator-cli/src/utils/graphQueries.ts (2)

164-171: Guard against empty results and limit nested results to 1 item.

Accessing result.snapshots[0].fallback[0] will throw when no snapshots/fallbacks exist. Also, you can ask The Graph for only the latest fallback.

Apply:

-          snapshots(where: {epoch: ${epoch}, inbox_: { id: "${veaInbox}" }}) {
-            fallback(orderBy: timestamp, orderDirection: desc){
+          snapshots(where: {epoch: ${epoch}, inbox_: { id: "${veaInbox}" }}) {
+            fallback(first: 1, orderBy: timestamp, orderDirection: desc){
               txHash
             }
           }

And add a null-safe return:

-    return result.snapshots[0].fallback[0];
+    const [firstSnapshot] = result.snapshots ?? [];
+    const [firstFallback] = firstSnapshot?.fallback ?? [];
+    return firstFallback;

---

178-185: Consider backward-compatibility for stateRoot.

If older snapshots lack stateRoot, the static type should reflect that to avoid accidental undefined access at runtime.

 type SnapshotSavedResponse = {
   snapshots: {
-    stateRoot: string;
+    stateRoot?: string;
     messages: {
       id: string;
     }[];
   }[];
 };

validator-cli/src/consts/bridgeRoutes.ts (3)

90-95: Type snapshotSavingPeriod explicitly and document units.

Improves clarity and prevents accidental key drift.

-// For the remaining time in an epoch the bot should save snapshots
-const snapshotSavingPeriod = {
+// For the remaining time (seconds) in an epoch the bot should save snapshots
+const snapshotSavingPeriod: Record<Network, number> = {
   [Network.DEVNET]: 90, // 1m 30s
   [Network.TESTNET]: 600, // 10 mins
 };

---

96-100: Improve error message and return the local variable.

Tiny polish; aids debugging without adding new validation.

 const getBridgeConfig = (chainId: number): Bridge => {
   const bridge = bridges[chainId];
-  if (!bridge) throw new Error(`Bridge not found for chain`);
-  return bridges[chainId];
+  if (!bridge) throw new Error(`Bridge not found for chainId=${chainId}`);
+  return bridge;
 };

Based on learnings.

---

14-23: Optional: tighten Bridge shapes (env-var fields).

If strictNullChecks is on, process.env.* are string | undefined. Consider asserting at load time or widening types here to string | undefined and validate upstream. Leaving as-is is acceptable if upper layers already validate.

Based on learnings.

validator-cli/src/watcher.ts (2)

17-17: Make RPC block range configurable (and possibly per-chain).

100 may be too conservative/too aggressive depending on provider. Suggest env override and per-network defaults.

-const RPC_BLOCK_LIMIT = 100; // RPC_BLOCK_LIMIT is the limit of blocks that can be queried at once
+const RPC_BLOCK_LIMIT = Number(process.env.RPC_BLOCK_LIMIT ?? 100); // blocks per getLogs/query

Optionally, add a per-chain map if providers differ.

---

139-141: Optional: derive currentEpoch from chain time, not local clock.

Local clock skew can misalign epoch. You already have outbox timestamps available.

-const currentEpoch = Math.floor(Date.now() / (1000 * routeConfig[network].epochPeriod));
+const latestOutboxBlock = await veaOutboxProvider.getBlock("latest");
+const currentEpoch = Math.floor(latestOutboxBlock.timestamp / routeConfig[network].epochPeriod);

validator-cli/README.md (2)

32-33: Example command should include the script path for consistency.

Use the same invocation style in both examples to avoid confusion.

-`pm2 start -- --saveSnapshot`
+`pm2 start dist/watcher.js -- --saveSnapshot`

---

18-27: Clarify defaults and flag interactions.

Document the default for --path and how --saveSnapshot behaves in challenger-only mode (ignored or error).

• Add: “Default: --path=both.”
• Add: “--saveSnapshot is only used when the bridger path is active.”

validator-cli/src/utils/transactionHandlers/arbToEthHandler.ts (1)

63-67: Guard against zero/too‑low fee caps from profitability heuristic.

If deposit/(gas*6) underflows to 0, tx may never land. Provide a sane floor or fallback to provider fee data.

-const maxFeePerGas = deposit / (toBigInt(gasEstimate) * BigInt(6));
-let maxPriorityFeePerGas = BigInt(6_667_000_000_000);
+const profitabilityCap = deposit / (toBigInt(gasEstimate) * BigInt(6));
+const minFee = BigInt(1_000_000_000); // 1 gwei floor; tune per network
+const maxFeePerGas = profitabilityCap > 0n ? profitabilityCap : minFee;
+let maxPriorityFeePerGas = 6_667_000_000_000n;
 if (maxPriorityFeePerGas > maxFeePerGas) {
   maxPriorityFeePerGas = maxFeePerGas;
 }

Confirm deposit is in wei (bigint) for all routes so the division stays in consistent units.

validator-cli/src/utils/claim.test.ts (1)

97-99: Typo in comment.

There’s a stray “ß” in the VerificationStarted comment; remove to avoid noise.

-        .mockImplementationOnce(() => Promise.resolve([])); // For VerificationStartedß
+        .mockImplementationOnce(() => Promise.resolve([])); // For VerificationStarted

validator-cli/src/utils/transactionHandlers/arbToGnosisHandler.ts (1)

68-75: Fee cap heuristic: add floor/ceil to avoid non‑includable txs.

Same concern as Arb→Eth: profitability division can yield 0; set a minimum and optionally cap priority fee.

-const maxFeePerGasProfitable = deposit / (toBigInt(gasEstimate) * BigInt(6));
-let maxPriorityFeePerGasMEV = BigInt(6667000000000);
+const cap = deposit / (toBigInt(gasEstimate) * 6n);
+const minFee = 1_000_000_000n; // 1 gwei floor
+const maxFeePerGasProfitable = cap > 0n ? cap : minFee;
+let maxPriorityFeePerGasMEV = 6_667_000_000_000n;
 if (maxPriorityFeePerGasMEV > maxFeePerGasProfitable) {
   maxPriorityFeePerGasMEV = maxFeePerGasProfitable;
 }

Verify deposit unit is wei across networks to ensure fee math correctness.

validator-cli/src/helpers/snapshot.test.ts (2)

124-125: Prefer ethers.ZeroHash over "0x0" to match contract zeros.

Literal "0x0" may not equal ZeroHash. Use the canonical constant to prevent false negatives.

-      veaInbox.snapshots.mockResolvedValue("0x0");
+      const { ZeroHash } = await import("ethers");
+      veaInbox.snapshots.mockResolvedValue(ZeroHash);

---

193-201: Test name reads opposite of its assertion.

It asserts that no snapshot is saved when snapshotNeeded is false. Rename for clarity.

-it("should not save snapshot if snapshot is needed", async () => {
+it("should not save snapshot if snapshot is NOT needed", async () => {

validator-cli/src/helpers/validator.ts (1)

77-85: Early-exit is fine; add stale-claim guard before withdrawing.

claim.honest !== 0 short‑circuits correctly, but claim may be stale. Before calling withdrawChallengeDeposit (Line 81), re‑fetch honest or rely on a quick resolve-state check to avoid unnecessary reverts if state flipped post-fetch.

Would you prefer a lightweight re-query of claimHashes/claim here, or to let the handler’s idempotency handle no-ops?

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: madhurMongia
PR: kleros/vea#359
File: validator-cli/src/ArbToEth/watcherArbToGnosis.ts:829-840
Timestamp: 2024-12-02T10:16:56.825Z
Learning: In the `validator-cli/src/ArbToEth/watcherArbToGnosis.ts` file, avoid adding redundant error handling in functions like `reconstructChallengeProgress` when error handling is already adequately managed.

Learnt from: mani99brar
PR: kleros/vea#424
File: validator-cli/src/utils/transactionHandlers/arbToEthHandler.ts:128-131
Timestamp: 2025-06-05T12:17:22.931Z
Learning: In the BaseTransactionHandler class, all transaction properties are expected to be initialized to null. When subclasses like ArbToEthDevnetTransactionHandler use spread syntax to extend the transactions object (e.g., `{ ...this.transactions, devnetAdvanceStateTxn: null }`), there's no issue with state loss since the base transactions are null initially.

Learnt from: mani99brar
PR: kleros/vea#370
File: bridger-cli/src/utils/transactionHandler.ts:64-77
Timestamp: 2024-12-09T09:42:34.067Z
Learning: In the `TransactionHandler` class (`bridger-cli/src/utils/transactionHandler.ts`), it's acceptable to let methods like `makeClaim` fail without additional error handling.

Learnt from: mani99brar
PR: kleros/vea#344
File: validator-cli/src/ArbToEth/watcherArbToEth.ts:732-745
Timestamp: 2024-11-27T04:18:05.872Z
Learning: In `validator-cli/src/ArbToEth/watcherArbToEth.ts`, input validation inside the `hashClaim` function is unnecessary because the upper layer ensures valid input before calling it.

Learnt from: mani99brar
PR: kleros/vea#424
File: validator-cli/src/helpers/claimer.ts:72-76
Timestamp: 2025-06-05T12:17:21.782Z
Learning: In validator-cli/src/helpers/claimer.ts, the outboxStateRoot captured at the beginning of the checkAndClaim function won't change for the epoch being claimed, so there's no race condition concern when reusing it in makeClaim/makeClaimDevnet functions.

Learnt from: madhurMongia
PR: kleros/vea#359
File: contracts/src/test/ArbToGnosis/VeaInboxArbToGnosisMock.sol:27-38
Timestamp: 2024-11-20T11:50:15.304Z
Learning: In `VeaInboxArbToGnosisMock.sendSnapshot`, `epochPeriod` is guaranteed to be non-zero, so a check for `epochPeriod > 0` is unnecessary.

Learnt from: mani99brar
PR: kleros/vea#370
File: bridger-cli/src/utils/claim.ts:56-69
Timestamp: 2024-12-09T10:54:57.068Z
Learning: In the TypeScript file 'bridger-cli/src/utils/claim.ts', the upper layers handle input validation for the 'hashClaim' function. Therefore, explicit input validation within 'hashClaim' is not necessary.

Learnt from: mani99brar
PR: kleros/vea#370
File: bridger-cli/src/utils/claim.ts:23-32
Timestamp: 2024-12-10T04:59:10.224Z
Learning: In `bridger-cli/src/utils/claim.ts`, within the `fetchClaim` function, when `claimData` is undefined, avoid initializing it with default values, as this can result in incorrect claim values and make issues harder to identify.

Learnt from: madhurMongia
PR: kleros/vea#359
File: validator-cli/src/ArbToEth/watcherArbToGnosis.ts:24-24
Timestamp: 2024-11-27T10:48:48.433Z
Learning: In the `validator-cli` codebase, both `arbitrumToEth` and `arbitrumToGnosis` modules use the same `ClaimStruct`, so importing `ClaimStruct` from either module is acceptable.

Learnt from: mani99brar
PR: kleros/vea#370
File: bridger-cli/src/consts/bridgeRoutes.ts:28-30
Timestamp: 2024-12-10T08:00:35.645Z
Learning: In `bridger-cli/src/consts/bridgeRoutes.ts`, additional validation in the `getBridgeConfig` function is unnecessary because error handling and validation are managed by upper layers in the application.

Learnt from: mani99brar
PR: kleros/vea#370
File: bridger-cli/src/utils/transactionHandler.ts:13-13
Timestamp: 2024-12-09T09:40:28.400Z
Learning: In `bridger-cli/src/utils/transactionHandler.ts`, the `veaOutbox` implementations differ for each chain, but a common interface should be defined for type checks to enhance type safety.