Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(config): unify cache directory to save in $HOME/.ormb #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2021
Merged

feat(config): unify cache directory to save in $HOME/.ormb #177

merged 1 commit into from
Apr 1, 2021

Conversation

@DanielQujun
Copy link
Contributor

@DanielQujun DanielQujun commented Mar 31, 2021 •
edited
Loading

When the config.yaml does not exists ormb will save config.json and cache in working directory, which is not consistent.

As Ormb desribes in PersistentFlags the default config path is $HOME/.ormb/config.yaml

rootCmd.PersistentFlags().StringVar(&cfgFile, "config", "", "config file (default is $HOME/.ormb/config.yaml)")

Maybe we can set rootPath default to $HOME/.ormb as we already do this in function initConfig

Does this PR introduce a user-facing change?:

Set default rootPath to $HOME/.ormb

Signed-off-by: 屈骏 [email protected]

@caicloud-bot caicloud-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 31, 2021
@gaocegege
Copy link
Member

/lgtm

/assign @simon-cj @FogDong

@gaocegege
Copy link
Member

/hold

@FogDong
Copy link
Member

FogDong commented Mar 31, 2021 •
edited
Loading

Thanks for your PR! ❤
Could u please add some release notes so that we can trace this modification in our next release?

@caicloud-bot caicloud-bot added lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 31, 2021
@gaocegege
Copy link
Member

/release-note-none

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 31, 2021
@DanielQujun
Copy link
Contributor Author

Thanks for your PR!
Could u please add some release notes so that we can trace this modification in our next release?

Done

FogDong
FogDong reviewed Apr 1, 2021
View reviewed changes
Copy link
Member

@FogDong FogDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel

@caicloud-bot caicloud-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2021
@caicloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FogDong, gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot merged commit 980a506 into kleveross:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FogDong FogDong FogDong left review comments

Assignees

@gaocegege gaocegege

@FogDong FogDong

@simon-cj simon-cj

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DanielQujun @gaocegege @FogDong @caicloud-bot @simon-cj