Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kmarius
Copy link
Owner

@kmarius kmarius commented Jul 30, 2022

Remove the redundant length field and make end_ind inclusive to make it more consistent with lua.

@L3MON4D3 Objections? If not I will also push a new release on luarocks.

@L3MON4D3
Copy link
Contributor

L3MON4D3 commented Aug 1, 2022

Luasnip doesn't use length at all, end-exclusive works pretty well for luasnip, but I agree that end-inclusive is more in line with luas stdlib (string.find), so I've no objections :)

@kmarius kmarius merged commit 5431f62 into master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants