Conversation
rhnvrm
previously requested changes
Mar 10, 2024
Collaborator
rhnvrm
left a comment
There was a problem hiding this comment.
When tests run, they run for the whole package. Since delim is defined in koanf_test.go file, we need to run both files while testing.
We should not remove the delim constant from maps_test.go in my opinion and use the same constant delim.
Maybe we can add a new test with empty delim for checking the edited logic.
codeboten
referenced
this pull request
in open-telemetry/opentelemetry-collector
Apr 9, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/knadh/koanf/v2](https://togithub.com/knadh/koanf) | `v2.1.0` -> `v2.1.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>knadh/koanf (github.com/knadh/koanf/v2)</summary> ### [`v2.1.1`](https://togithub.com/knadh/koanf/releases/tag/v2.1.1) [Compare Source](https://togithub.com/knadh/koanf/compare/v2.1.0...v2.1.1) #### What's Changed - fix: run submodule tests by [@​rhnvrm](https://togithub.com/rhnvrm) in [https://github.com/knadh/koanf/pull/276](https://togithub.com/knadh/koanf/pull/276) - Bump google.golang.org/protobuf from 1.30.0 to 1.33.0 in /examples by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/knadh/koanf/pull/282](https://togithub.com/knadh/koanf/pull/282) - Bump google.golang.org/protobuf from 1.30.0 to 1.33.0 in /providers/etcd by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/knadh/koanf/pull/281](https://togithub.com/knadh/koanf/pull/281) - Bump google.golang.org/protobuf from 1.30.0 to 1.33.0 in /providers/nats by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/knadh/koanf/pull/280](https://togithub.com/knadh/koanf/pull/280) - feat: add ParserEnvWithValue by [@​tlipoca9](https://togithub.com/tlipoca9) in [https://github.com/knadh/koanf/pull/284](https://togithub.com/knadh/koanf/pull/284) - Fix map unflattening no-delimiter behaviour by [@​knadh](https://togithub.com/knadh) in [https://github.com/knadh/koanf/pull/278](https://togithub.com/knadh/koanf/pull/278) #### New Contributors - [@​tlipoca9](https://togithub.com/tlipoca9) made their first contribution in [https://github.com/knadh/koanf/pull/284](https://togithub.com/knadh/koanf/pull/284) **Full Changelog**: knadh/koanf@v2.1.0...v2.1.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]> Co-authored-by: Alex Boten <[email protected]>
|
@knadh is there a release with this fix? I seem to experiencing this bug I am importing which are indirectly bringing As per https://pkg.go.dev/github.com/knadh/koanf/maps the last release is from 2023. Thanks so much for the help. |
knadh
added a commit
that referenced
this pull request
Apr 1, 2025
Owner
Author
|
@nhertzulis I'd missed tagging the fix. Just pushed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rhnvrm please take a look at the commit that fixes the undefined variable
delim. I'm wondering how all the tests were passing despitemaps_test.gohaving a compile error.Closes #275