changing cliflagv2 to support variadic forcedinclude parameter#357
Merged
knadh merged 2 commits intoknadh:masterfrom May 16, 2025
kooroo:forceinclude_cliflagv2
Merged
changing cliflagv2 to support variadic forcedinclude parameter#357knadh merged 2 commits intoknadh:masterfrom kooroo:forceinclude_cliflagv2
knadh merged 2 commits intoknadh:masterfrom
kooroo:forceinclude_cliflagv2
Conversation
Owner
|
I think the better approach is to add a new function |
…tead of a variadic.
Contributor
Author
I made changes. Does this fit better with what you were thinking? you have to load it via something like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proposed change to address #356
this changes the provider function definition to a variadic one that allows passing a []string at the end which lists flags that should be loaded up even if they weren't set explicitly (default values). This should preserve current functionality for any current code using this provider without breaking, but enable calling the provider via
which will load flag1 and flag3 into the koanf object with whatever they contain (default values, zero values, other shenaniganery and tomfoolery).