Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Reverting the namespace rename knative-monitoring #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2018
Merged

Reverting the namespace rename knative-monitoring #486

merged 1 commit into from
Oct 30, 2018

Conversation

@RichieEscarez
Copy link
Contributor

knative-monitoring does not work in serving 0.1.x
#437

@knative-prow-robot knative-prow-robot added approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 30, 2018
@labadav labadav self-assigned this Oct 30, 2018
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2018
labadav
labadav approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@labadav labadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: labadav, RichieEscarez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RichieEscarez,labadav]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RichieEscarez RichieEscarez merged commit ddbe40e into knative:master Oct 30, 2018
@RichieEscarez RichieEscarez deleted the revert-knative-monitoring branch November 6, 2018 21:35
@NOUIY NOUIY mentioned this pull request Aug 21, 2023
Closed
@NOUIY NOUIY mentioned this pull request Mar 28, 2024
Closed
@NOUIY NOUIY mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@yanweiguo yanweiguo Awaiting requested review from yanweiguo

1 more reviewer

@labadav labadav labadav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@labadav labadav

Labels

lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RichieEscarez @knative-prow-robot @labadav