Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@samodell
Copy link
Contributor

Some install commands had an extra --filename flag and were using incorrect slashes, same as #736 ; also fixes that issue

@samodell samodell requested a review from carieshmarie January 10, 2019 17:40
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 10, 2019
@bbrowning
Copy link
Contributor

I manually verified the new install instructions for 0.3 on GKE and visually checked the other changes here. I did have to kubectl apply the serving and build yamls twice because of a known issue around defining and using CustomResourceDefinitions from a single yaml file. I'll separately ensure there's an issue filed to track that, as that change is unrelated to the version bumping here.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2019
@knative-prow-robot knative-prow-robot merged commit f97bb69 into knative:master Jan 10, 2019
@samodell samodell deleted the fixInstalls branch January 10, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants