Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@bradylove
Copy link

Proposed Changes

This PR removes a duplicate --filename flag as well as replaces forward slashes with back slashes in the kubectl apply command for installing Knative.

This PR removes a duplicate `--filename` flag as well as replaces forward slashes with back slashes in the `kubectl apply` command for installing Knative.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bradylove
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: vaikas-google

If they are not already assigned, you can assign the PR to them by writing /assign @vaikas-google in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 10, 2019
@knative-prow-robot
Copy link
Contributor

Hi @bradylove. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bradylove
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@bradylove
Copy link
Author

/assign @vaikas-google

@samodell
Copy link
Contributor

Thanks for your PR! PR #736 was opened a few hours earlier to fix that issue; so closing this one out.

@samodell samodell closed this Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants