Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@pierDipi
Copy link
Member

Waiting for knative-extensions/eventing-integrations#72 to be merged and built

Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
@knative-prow
Copy link

knative-prow bot commented Feb 24, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2025
@knative-prow knative-prow bot requested review from Cali0707 and mgencur February 24, 2025 12:56
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 24, 2025
@pierDipi pierDipi force-pushed the event-transform-e2e-tests branch from f60a678 to 3e77fec Compare February 24, 2025 13:01
@codecov
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.81%. Comparing base (c651616) to head (3e77fec).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8499      +/-   ##
==========================================
+ Coverage   62.62%   62.81%   +0.18%     
==========================================
  Files         396      396              
  Lines       24231    24231              
==========================================
+ Hits        15175    15221      +46     
+ Misses       8247     8201      -46     
  Partials      809      809              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matzew
Copy link
Member

matzew commented Feb 24, 2025

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2025
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2025
@pierDipi pierDipi marked this pull request as ready for review February 24, 2025 13:51
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2025
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2025
@knative-prow
Copy link

knative-prow bot commented Feb 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member

matzew commented Feb 24, 2025

/test unit-tests

2 similar comments
@pierDipi
Copy link
Member Author

/test unit-tests

@pierDipi
Copy link
Member Author

/test unit-tests

@matzew
Copy link
Member

matzew commented Feb 24, 2025

/retest

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@pierDipi pierDipi force-pushed the event-transform-e2e-tests branch from a6aaf16 to 0e77d7d Compare February 24, 2025 15:25
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2025
@pierDipi
Copy link
Member Author

/test unit-tests

1 similar comment
@pierDipi
Copy link
Member Author

/test unit-tests

@pierDipi pierDipi requested a review from matzew February 24, 2025 16:17
@pierDipi
Copy link
Member Author

Sorry @matzew, I picked the wrong image SHA earlier, now it works

@pierDipi
Copy link
Member Author

/test unit-tests

@matzew
Copy link
Member

matzew commented Feb 24, 2025

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2025
@knative-prow knative-prow bot merged commit ae049c8 into knative:main Feb 24, 2025
29 of 35 checks passed
matzew pushed a commit to matzew/eventing that referenced this pull request Mar 18, 2025
* E2E tests

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* EventTransform Jsonata e2e tests

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Use eventing-integrations images and fix tests

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Verify response status code received by source

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Update JSONata transformations

Signed-off-by: Pierangelo Di Pilato <[email protected]>

---------

Signed-off-by: Pierangelo Di Pilato <[email protected]>
matzew pushed a commit to matzew/eventing that referenced this pull request Mar 19, 2025
* E2E tests

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* EventTransform Jsonata e2e tests

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Use eventing-integrations images and fix tests

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Verify response status code received by source

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Update JSONata transformations

Signed-off-by: Pierangelo Di Pilato <[email protected]>

---------

Signed-off-by: Pierangelo Di Pilato <[email protected]>
openshift-merge-bot bot pushed a commit to openshift-knative/eventing that referenced this pull request Mar 21, 2025
* Partial implementation of certmanager for integration sink (knative#8481)

* Adding cert-mananger bits
Basics for Cert-manager

Signed-off-by: Matthias Wessendorf <[email protected]>

* Adding create cert manifest function

Signed-off-by: Matthias Wessendorf <[email protected]>

* Use the make cert

Signed-off-by: Matthias Wessendorf <[email protected]>

* Reconcile Certificate manifest and add RBAC

Signed-off-by: Matthias Wessendorf <[email protected]>

* Add secret filter to controller

Signed-off-by: Matthias Wessendorf <[email protected]>

* Look up secrets/certs for sink

Signed-off-by: Matthias Wessendorf <[email protected]>

* Remove old/wrong Certificate manifest and reference

Signed-off-by: Matthias Wessendorf <[email protected]>

* Fix controller compile

Signed-off-by: Matthias Wessendorf <[email protected]>

* Formatting

Signed-off-by: Matthias Wessendorf <[email protected]>

* change the reconcile of cert manifest, and run it only w/ some form of TLS

Signed-off-by: Matthias Wessendorf <[email protected]>

* using filtered informer

Signed-off-by: Matthias Wessendorf <[email protected]>

* Adding Rekt test for IntegrationSink TLS support

Signed-off-by: Matthias Wessendorf <[email protected]>

* adding a bit of https port for deployment/service of the IntegrationSink

Signed-off-by: Matthias Wessendorf <[email protected]>

* Mounting secrets and setting quarkus env vars for TLS support

Signed-off-by: Matthias Wessendorf <[email protected]>

* Adding flags for different TLS levels resulting in diffeerent quarkus env vars

Signed-off-by: Matthias Wessendorf <[email protected]>

* Remove bad comment

Signed-off-by: Matthias Wessendorf <[email protected]>

* Adding label

Signed-off-by: Matthias Wessendorf <[email protected]>

* Update codegen

Signed-off-by: Matthias Wessendorf <[email protected]>

* Disable tmp. the cert manager feature

Signed-off-by: Matthias Wessendorf <[email protected]>

* Fixing header/year

Signed-off-by: Matthias Wessendorf <[email protected]>

* More test tweaking

Signed-off-by: Matthias Wessendorf <[email protected]>

* Remove unused and comment out the hooks for now

Signed-off-by: Matthias Wessendorf <[email protected]>

---------

Signed-off-by: Matthias Wessendorf <[email protected]>

* Run make generate-release

Signed-off-by: Matthias Wessendorf <[email protected]>

* Remove unused code (knative#8485)

Signed-off-by: Matthias Wessendorf <[email protected]>

* IntegrationSink prefactors (knative#8486)

Little refactors on IntegrationSink

Signed-off-by: Matthias Wessendorf <[email protected]>

* Add initial iteration of eventing-integration resources (knative#8493)

* Generic code for Certificates (knative#8489)

Make Certifacte factory more generic

Signed-off-by: Matthias Wessendorf <[email protected]>

* Jsonata Event transform e2e tests (knative#8499)

* E2E tests

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* EventTransform Jsonata e2e tests

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Use eventing-integrations images and fix tests

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Verify response status code received by source

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Update JSONata transformations

Signed-off-by: Pierangelo Di Pilato <[email protected]>

---------

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Inject integration images from ConfigMap (knative#8500)

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Run make generate-release

Signed-off-by: Matthias Wessendorf <[email protected]>

* Update to the correct file (knative#8507)

Signed-off-by: Matthias Wessendorf <[email protected]>

* EventTransform: Inject tracing configurations (knative#8479)

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* EventTransform: add reconciler unit tests (knative#8513)

* EventTransform: add reconciler unit tests

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Update pkg/reconciler/testing/v1alpha1/eventtransform.go

Co-authored-by: Marek Schmidt <[email protected]>

---------

Signed-off-by: Pierangelo Di Pilato <[email protected]>
Co-authored-by: Marek Schmidt <[email protected]>

* Enable Cert Manager (knative#8509)

* Re-enable Cert Mgr

Signed-off-by: Matthias Wessendorf <[email protected]>

* Manual informer

Signed-off-by: Matthias Wessendorf <[email protected]>

* Update main

Signed-off-by: Matthias Wessendorf <[email protected]>

* update controller

Signed-off-by: Matthias Wessendorf <[email protected]>

* Adding label on cert

Signed-off-by: Matthias Wessendorf <[email protected]>

* add enqueue

Signed-off-by: Matthias Wessendorf <[email protected]>

* Create Cert Informer, on demand, and cancle when flag is disabled

Signed-off-by: Matthias Wessendorf <[email protected]>

* Update unit tests that broke during rrefactors

Signed-off-by: Matthias Wessendorf <[email protected]>

---------

Signed-off-by: Matthias Wessendorf <[email protected]>

* Event Transform JSONata TLS (knative#8515)

* Event Transform JSONata TLS

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* HA and security context

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Reconcile Certificate

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Additional unit tests cases

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Fix tests

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* EventTransform trust bundle propagation and tests

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Fix tests and address comments

Signed-off-by: Pierangelo Di Pilato <[email protected]>

---------

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Run make generate-release

Signed-off-by: Matthias Wessendorf <[email protected]>

* Add dynamic cert-manager certificates informer (knative#8517)

* Add dynamic informer, part I

Signed-off-by: Matthias Wessendorf <[email protected]>

* Add Dynamic certificates informer for EventTransform

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Add Dynamic certificates Informer to IntegrationSink

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Fix error message

Signed-off-by: Pierangelo Di Pilato <[email protected]>

---------

Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Co-authored-by: Pierangelo Di Pilato <[email protected]>

* Improve CM Cert reconcile and deletion if feature is turned off (knative#8519)

refactor CM Cert reconciler and take care of delete if feature is disabled

Signed-off-by: Matthias Wessendorf <[email protected]>

* Remove transformations and integrations ConfigMaps (#1201)

We don't use the ConfigMaps to inject the values, the operator
will replace the value to the images directly.

Signed-off-by: Pierangelo Di Pilato <[email protected]>
Co-authored-by: Pierangelo Di Pilato <[email protected]>

* Run make generate-release

Signed-off-by: Matthias Wessendorf <[email protected]>

* Add configmaps/finalizers permissions

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Add update finalizers permissions for EventTransform reconciled resources

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Volume mounts use direct

Signed-off-by: Matthias Wessendorf <[email protected]>

* Fix EventTransform with TLS Sink test

Signed-off-by: Matthias Wessendorf <[email protected]>

---------

Signed-off-by: Matthias Wessendorf <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Co-authored-by: David Simansky <[email protected]>
Co-authored-by: Pierangelo Di Pilato <[email protected]>
Co-authored-by: Marek Schmidt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants