SinkBinding: Set specific conditions for reconciler steps #8508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Instead of setting the ready condition during reconciliation steps, set specific conditions since the ready condition is managed and set according to the state of other conditions. Signed-off-by: Pierangelo Di Pilato <[email protected]>
a7c75de to
45905c7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8508 +/- ##
==========================================
+ Coverage 62.81% 62.83% +0.01%
==========================================
Files 396 396
Lines 24233 24235 +2
==========================================
+ Hits 15223 15227 +4
+ Misses 8201 8199 -2
Partials 809 809 ☔ View full report in Codecov by Sentry. |
matzew
reviewed
Feb 26, 2025
|
|
||
| if err := s.propagateTrustBundles(ctx, sb); err != nil { | ||
| sb.Status.MarkBindingUnavailable("TrustBundlePropagation", err.Error()) | ||
| sb.Status.MarkFailedTrustBundlePropagation("FailedTrustBundlePropagation", err.Error()) |
|
/lgtm |
|
/retest |
|
/test upgrade-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of setting the ready condition during reconciliation steps, set specific conditions since the ready condition is managed and set according to the state of other conditions.
Fixes #
Proposed Changes
Pre-review Checklist
Release Note
Docs