Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow storage-version-migration job to successfully run when optional CRDs are not installed (inmemorychannels, etc) #8510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2025
Merged

Allow storage-version-migration job to successfully run when optional CRDs are not installed (inmemorychannels, etc) #8510

merged 2 commits into from
Mar 6, 2025

Conversation

@PinotNoir04
Copy link
Contributor

@PinotNoir04 PinotNoir04 commented Feb 26, 2025 •
edited by pierDipi
Loading

Fixes #8415

Proposed Changes

  • Set the the IGNORE_NOT_FOUND environment variable to true in the storage-version-migrator.yaml file

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Allow storage-version-migration job to successfully run when optional CRDs are not installed (inmemorychannels, etc).

Docs

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 26, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: PinotNoir04 / name: Rishav Ray Chaudhury (2bd40ab, 079e0d5)

@knative-prow
Copy link

knative-prow bot commented Feb 26, 2025

Welcome @PinotNoir04! It looks like this is your first PR to knative/eventing 🎉

@knative-prow
Copy link

knative-prow bot commented Feb 26, 2025

Hi @PinotNoir04. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 26, 2025
@knative-prow knative-prow bot requested review from Leo6Leo and aliok February 26, 2025 16:34
@pierDipi pierDipi changed the title Postinstallation Job "storage-version-migration-eventing" inmemorychannels Allow storage-version-migration job to successfully run when optional CRDs are not installed (inmemorychannels, etc) Feb 27, 2025
@pierDipi
Copy link
Member

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 27, 2025
@codecov
Copy link

codecov bot commented Feb 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.78%. Comparing base (3153b47) to head (2bd40ab).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8510   +/-   ##
=======================================
  Coverage   62.78%   62.78%           
=======================================
  Files         396      396           
  Lines       24241    24241           
=======================================
  Hits        15220    15220           
  Misses       8211     8211           
  Partials      810      810

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PinotNoir04
Copy link
Contributor Author

Hey @pierDipi, thanks for looking into the PR. Could you tell me where I am going wrong here? Thanks again for your time.

@pierDipi
Copy link
Member

The error is:

    executor.go:189: Feb 27 10:54:52.510 install_post_install_job [ERR] Error from server (BadRequest): error when creating "/tmp/knative.380LDNA6/ci-2025-02-27-10-54-05-heZtLtqAa1/eventing-post-install.yaml":

It seems that the job is invalid, I think you need to quote the true -> "true"

pierDipi
pierDipi reviewed Feb 27, 2025
View reviewed changes
config/post-install/storage-version-migrator.yaml Outdated
image: ko://knative.dev/pkg/apiextensions/storageversion/cmd/migrate
env:
- name: IGNORE_NOT_FOUND
value: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
value: true
value: "true"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made the change. should I run /retest ?

@pierDipi
Copy link
Member

pierDipi commented Mar 6, 2025

/test reconciler-tests

pierDipi
pierDipi approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2025
@knative-prow
Copy link

knative-prow bot commented Mar 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, PinotNoir04

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2025
@knative-prow knative-prow bot merged commit 615a071 into knative:main Mar 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierDipi pierDipi pierDipi approved these changes

@aliok aliok Awaiting requested review from aliok

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees

@pierDipi pierDipi

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Postinstallation Job "storage-version-migration-eventing" inmemorychannels

2 participants

@PinotNoir04 @pierDipi