Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Cali0707
Copy link
Member

Fixes #8318

Proposed Changes

  • Add a CESQL function for verifying correlation ids
  • Add unit tests for trigger filters with the CESQL function registered
  • Change the VerifyCorrelationId interface to allow the CESQL function definition to be more idiomatic

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Knative now supports the KN_VERIFY_CORRELATION_ID CESQL function, allowing you to verify knative correlation ids in your trigger filters.

Docs

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 24, 2025
@Cali0707
Copy link
Member Author

/cc @matzew @dsimansk @aliok

@knative-prow knative-prow bot requested review from aliok, aslom, dsimansk and matzew June 24, 2025 13:58
@knative-prow
Copy link

knative-prow bot commented Jun 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from Leo6Leo June 24, 2025 13:58
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2025
@codecov
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 52.35%. Comparing base (5de389b) to head (eb28590).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/requestreply/cesql.go 83.33% 4 Missing and 2 partials ⚠️
pkg/requestreply/correlation_id.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8608      +/-   ##
==========================================
+ Coverage   52.30%   52.35%   +0.04%     
==========================================
  Files         398      399       +1     
  Lines       25040    25072      +32     
==========================================
+ Hits        13097    13126      +29     
- Misses      11143    11145       +2     
- Partials      800      801       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Cali0707 added 2 commits June 24, 2025 10:05
Signed-off-by: Calum Murray <[email protected]>
@matzew
Copy link
Member

matzew commented Jun 24, 2025

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2025
@knative-prow knative-prow bot merged commit 7f047f9 into knative:main Jun 24, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RequestReply: Add CESQL function

2 participants