Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: instrument jobsink with otel #8639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

feat: instrument jobsink with otel #8639

merged 1 commit into from
Jul 16, 2025

Conversation

@Cali0707
Copy link
Member

Proposed Changes

  • Setup OTel in the JobSink handler
  • Record dispatch metrics in the JobSink handler
The JobSink now reports metrics with OTel

@knative-prow
Copy link

knative-prow bot commented Jul 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 16, 2025
@Cali0707
Copy link
Member Author

/cc @creydr @evankanderson

@codecov
Copy link

codecov bot commented Jul 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 68 lines in your changes missing coverage. Please review.

Project coverage is 52.07%. Comparing base (bedd48f) to head (1825288).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/jobsink/main.go 0.00% 44 Missing ⚠️
pkg/observability/newcontext.go 0.00% 24 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8639      +/-   ##
==========================================
- Coverage   52.17%   52.07%   -0.11%     
==========================================
  Files         401      401              
  Lines       25199    25248      +49     
==========================================
  Hits        13148    13148              
- Misses      11261    11310      +49     
  Partials      790      790

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

evankanderson
evankanderson reviewed Jul 16, 2025
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2025
@knative-prow knative-prow bot merged commit fd509a9 into knative:main Jul 16, 2025
35 of 36 checks passed
@Cali0707 Cali0707 mentioned this pull request Jul 17, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson evankanderson left review comments

@creydr creydr Awaiting requested review from creydr

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

Assignees

@evankanderson evankanderson

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Cali0707 @evankanderson