Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #8626

Event files received by Jobsinks will now include the Distributed Tracing extension

@knative-prow knative-prow bot requested review from creydr and pierDipi August 6, 2025 18:48
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 6, 2025
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2025
@knative-prow
Copy link

knative-prow bot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@codecov
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 54.16667% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.44%. Comparing base (7ea8857) to head (f362107).
⚠️ Report is 1 commits behind head on release-1.19.

Files with missing lines Patch % Lines
pkg/tracing/populate_ce_distributed_tracing.go 56.52% 10 Missing ⚠️
cmd/jobsink/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.19    #8657   +/-   ##
=============================================
  Coverage         51.44%   51.44%           
=============================================
  Files               399      400    +1     
  Lines             25116    25139   +23     
=============================================
+ Hits              12921    12934   +13     
- Misses            11413    11423   +10     
  Partials            782      782           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Cali0707
Copy link
Member

Cali0707 commented Aug 7, 2025

/test reconciler-tests

1 similar comment
@matzew
Copy link
Member

matzew commented Aug 11, 2025

/test reconciler-tests

@matzew
Copy link
Member

matzew commented Aug 11, 2025

/retest

@knative-prow knative-prow bot merged commit 6aadceb into knative:release-1.19 Aug 11, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants