Thanks to visit codestin.com
Credit goes to github.com

Skip to content

remove prometheus from tracing protocol #8665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 15, 2025
Merged

remove prometheus from tracing protocol #8665

merged 2 commits into from
Aug 15, 2025

Conversation

@dprotaso
Copy link
Member

No description provided.

@dprotaso
Copy link
Member Author

/assign @Cali0707

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 14, 2025
@knative-prow knative-prow bot requested review from Leo6Leo and matzew August 14, 2025 18:38
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2025
@dprotaso
Copy link
Member Author

/cherry-pick release-1.19

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Aug 14, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.45%. Comparing base (23fa820) to head (f062422).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8665   +/-   ##
=======================================
  Coverage   51.44%   51.45%           
=======================================
  Files         400      400           
  Lines       25138    25138           
=======================================
+ Hits        12933    12934    +1     
+ Misses      11425    11422    -3     
- Partials      780      782    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Cali0707
Cali0707 approved these changes Aug 14, 2025
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2025
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2025
@dprotaso
Copy link
Member Author

Had to update the checksum

@Cali0707
Copy link
Member

/test reconciler-tests

matzew
matzew approved these changes Aug 15, 2025
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2025
@knative-prow
Copy link

knative-prow bot commented Aug 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, dprotaso, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Cali0707,dprotaso,matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 81cbeaa into knative:main Aug 15, 2025
31 of 32 checks passed
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #8666

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Aug 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew approved these changes

@Cali0707 Cali0707 Cali0707 approved these changes

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees

@matzew matzew

@Cali0707 Cali0707

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dprotaso @knative-prow-robot @Cali0707 @matzew