Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: add ResolveTableType for .merge() #5605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2023
Merged

fix: add ResolveTableType for .merge() #5605

merged 1 commit into from
Jul 4, 2023

Conversation

jeengbe
Copy link
Contributor

@jeengbe jeengbe commented Jun 19, 2023

Regression of #4246

Fixes #4246

@coveralls
Copy link

coveralls commented Jun 19, 2023 •
edited
Loading

Coverage Status

coverage: 92.785%. remained the same when pulling af34e4d on jeengbe:patch-1 into 9e5fdfa on knex:master.

@jeengbe
Copy link
Contributor Author

jeengbe commented Jun 19, 2023 •
edited
Loading

That test failure does not look related to my changes

  2) Query Building Tests
       mysql2 SchemaBuilder
         views
           "before all" hook for "basic create view":
     Error: Knex: run
$ npm install mysql2 --save
Unexpected token '('
      at Client_MySQL2.initializeDriver (lib/client.js:194:13)

@OlivierCavadenti OlivierCavadenti merged commit c8da0df into knex:master Jul 4, 2023
@jeengbe jeengbe deleted the patch-1 branch July 7, 2023 10:15
@hashim21223445 hashim21223445 mentioned this pull request Aug 7, 2024
Open
@WesleyR10 WesleyR10 mentioned this pull request Aug 22, 2024
Open
@doperiddle doperiddle mentioned this pull request Nov 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OlivierCavadenti OlivierCavadenti OlivierCavadenti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

onConflict/merge don't work with Knex.CompositeTableType

3 participants

@jeengbe @coveralls @OlivierCavadenti