Ensure test DB exists at correct path in better-sqlite3 tests #5608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
240fda8 to
540dc96
Compare
540dc96 to
3e3ccfc
Compare
|
Hi, @OlivierCavadenti! Sorry about the test issue; this PR should get them passing again. |
3e3ccfc to
f697095
Compare
OlivierCavadenti
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #5530. Better-SQLite3 tests weren't passing on all platforms due to a path / sequencing issue. This PR addresses the issue by using
path.resolve()instead of constructing paths by string addition, and by ensuring that an empty database exists no matter what order the tests run in.