Missing comments on delete, update and insert #5738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Few monthes ago comments where included in query, but only in select statement. Here is the code to make delete, update and insert compatible with comments
|
@sebastienroul could you please add tests? |
|
@kibertoad Hi, yes sure, but can you give me pointer to the test written for the select statement please, I cant find them (µI'd like to use them as template). For your info PR is working like a charm on 10 of our projects :) |
|
@kibertoad : Finally, unit test + integration test are there. |
|
thanks! |
|
Released in 3.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few monthes ago comments where included in query, but only in select statement. Here is the code to make delete, update and insert compatible with comments