Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

viraxslot
Copy link
Contributor

Closes: #4769
Knex documentation update: knex/documentation#556

Done:

  • added upsert implementation for MySQL
  • added unit tests
  • added integration tests

MySQL docs: https://dev.mysql.com/doc/refman/8.0/en/replace.html

@viraxslot
Copy link
Contributor Author

@kibertoad could you please have a look?

@coveralls
Copy link

coveralls commented Nov 27, 2023

Coverage Status

coverage: 92.795% (+0.02%) from 92.778%
when pulling 5cf1157 on viraxslot:mysql-upsert
into 1d7707e on knex:master.

@kibertoad kibertoad merged commit 04642da into knex:master Nov 28, 2023
@kibertoad
Copy link
Collaborator

thanks a lot!

@viraxslot viraxslot deleted the mysql-upsert branch November 28, 2023 00:40
@viraxslot
Copy link
Contributor Author

viraxslot commented Dec 22, 2023

@kibertoad Hi, I see that the related PR in documentation is still open. Should we merge it maybe? Sorry, I don't know what's the right flow is. I mentioned it in the description btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use REPLACE to implement Upsert operation for MySQL

3 participants