Infer specific column value type in aggregations #5297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first overload of TypePreservingAggregation (taking columnName and options) used `Readonly<TKey>` for the columnName type. In this context, `TKey` is supposed to be a single column name, but `Readonly<TKey>` maps over the full constraint of `ResolveTableType<TRecord>`. This results in `TKey` being a union of all keys in the table, rather than a single key. Because of this, the result type ends up being a union of all values in the table. The fix is to remove the `Readonly` type, which is fine since `TKey` is a string and not an object like in the other overloads.
OlivierCavadenti
approved these changes
Aug 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hi folks, thanks for a great library! I came across what looks like a typing bug to me:
The first overload of TypePreservingAggregation (taking columnName and options) used
Readonly<TKey>for the columnName type. In this context,TKeyis supposed to be a single column name, butReadonly<TKey>maps over the full constraint ofkeyof ResolveTableType<TRecord>.This results in
TKeybeing a union of all keys in the table, rather than a single key. Because of this, the result type ends up being a union of all values in the table.The fix is to remove the
Readonlytype, which is fine sinceTKeyis a string and not an object like in the other overloads.