feat: support partial unique indexes #5316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abalabahaha unit tests are failing |
|
@kibertoad sorry about that, I must have missed those since random tests were timing out on my computer. I fixed the failed tests |
kibertoad
approved these changes
Sep 1, 2022
|
Any idea when this will be released? |
|
This was released in 2.4.0, sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds MSSQL, PostgreSQL, and SQLite support for partial unique indexes, heavily based on #4768.
The Postgres driver defaults to creating a unique constraint instead of an index, so Postgres support for
useConstraintwas added, defaulting totruewithout predicate andfalsewith predicate. The alternative would be to always default touseConstraint: true, but thenpredicatewould error by default unlessuseConstraint: falseis explicitly specified. Dunno which is better.Docs: knex/documentation#449
Fixes #4870