-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[ISSUE-5350] Create EXCEPT as a valid keyword #5357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-5350] Create EXCEPT as a valid keyword #5357
Conversation
|
is there any progress on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks a lot of tests by removing all assertions from them.
Please add assertions to all new tests and restore them in prior ones.
This PR doesn't edit any previous tests, it only indents them to meet linting standards. I'm happy to add new assertions to the old tests to make them usable but was unsure if this was expected. |
|
@dvsweeney9 Ah, apologies, tests shifted visually a lot, so old tests without assertions look like they replaced the other ones which had assertions. No need to fix old ones (although that would also be welcome), but if you could add assertions to new tests, that should suffice, and this PR could be merged then. |
|
@kibertoad I ended up adding assertions to the old tests as well as the new tests and restructured them to match the |
|
@kibertoad quick ping |
Sorry, I dismiss to merge it, tests are ok
Addresses #5350
Except is a valid SQL keyword https://www.tutorialspoint.com/sql/sql-except-clause.htm
This is functionality that is blocking my project.
Summary
.except()as a function to the query builder..except()works exactly like.union()or.intersect()..intersect()to use reusable code..except()that mimic those of.intersect().The documentation PR is available here: knex/documentation#468