feat(pg): implement QueryBuilder#updateFrom #5386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, looks like I've not fully understood how the testsuite works; its attempting to run pg-specific QB methods against other DB engines. Is there documentation on how to correctly place my tests so that they only run against the correct DB engine(s) during CI? |
I've not done an exhaustive search, but I know that (and am in need of support for) PostgreSQL handles this. |
e9ee84a to
460f4cf
Compare
OlivierCavadenti
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation PR: knex/documentation#476
Introduces the
updateFromquerybuilder method for PostgreSQL. This allows the creation ofUPDATE <table> SET <data> FROM <name>queries, which may reference relations or CTEs outside of the target table.I opted for creating a new QB method (
updateFrom) to avoid conflict or weird interactions or unexpected changes to behaviour with the target table already being inferred fromknex(table),knex.table(table), etc.