Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(swaps): status is expired field #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vikiival merged 5 commits into from
Nov 10, 2025
Merged

fix(swaps): status is expired field #357

vikiival merged 5 commits into from
Nov 10, 2025

Conversation

@hassnian
Copy link
Contributor

@hassnian hassnian commented Nov 5, 2025

closes #356

@hassnian hassnian requested a review from vikiival November 5, 2025 09:37
@hassnian
Copy link
Contributor Author

hassnian commented Nov 5, 2025 •
edited
Loading

kk so what should be done on the indexer side ?

@vikiival something like this, do you know if validationCall.args?.data?.validationData?.relayParentNumber is always accessible this way or present? if yes ill make it non nullable

this validationCall.args looks like

{
  data: {
    validationData: {
      parentHead: '0x448eecadc3672f34a6d3a37c39567e1699c9cde0d99b047568aa44b2c6ab0ff2eac67202e54635d79d1788bfe1acde026de6f873ed98e0185417dce1a42b369bf56729200aa295580524e7594aa18860c4941da0bf15152b3f79ba3258e770be7ca183f00c06617572612006edc008000000000452505352900ff2aec13786e7f0627eef4973a95d812732590580d3133029b7b6dfe6a9584146e5cb06056175726101011236baad6289adbff502b2bed2214ea5c8c51a43c8694cdfa8d347c0f12e8b8925638b6afb747857c00904e02312bf440a9de2def9ca6d514468235e7801b400',
      relayParentNumber: 28506450,
      relayParentStorageRoot: '0x059a98027d1cdf137dc517c834431b2e1e2a571c92ba7ad7642575a6831960c6',
      maxPovSize: 10485760
    },
    relayChainState: { trieNodes: [Array] },
    relayParentDescendants: [],
    collatorPeerId: undefined
  },
  inboundMessagesData: {
    downwardMessages: { fullMessages: [], hashedMessages: [] },
    horizontalMessages: { fullMessages: [], hashedMessages: [] }
  }
}

@hassnian hassnian changed the title fix(swaps): capture and use relayParentNumber for swaps status is fix(swaps): status is expired field Nov 5, 2025
vikiival
vikiival approved these changes Nov 6, 2025
View reviewed changes
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go

@hassnian
Copy link
Contributor Author

hassnian commented Nov 7, 2025 •
edited
Loading

forgot we also had swaps were expired here 47ba195

tested and it works

CleanShot 2025-11-07 at 12 07 10@2x

@vikiival pls merge and deploy it, thanks

@vikiival vikiival merged commit e00d38f into main Nov 10, 2025
2 checks passed
@vikiival vikiival deleted the fix/swaps-expiration-status branch November 10, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikiival vikiival vikiival approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Atomic swaps wrong ’expiration’

3 participants

@hassnian @vikiival