Treat GoogleTest as a TPL and build it via FetchContent #8606
+46
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
commented
Oct 25, 2025
Comment on lines
+7
to
+12
| if(ALL_KOKKOS_COMPILER_FLAGS) | ||
| set_target_properties(gtest PROPERTIES COMPILE_FLAGS ${ALL_KOKKOS_COMPILER_FLAGS}) | ||
| endif() | ||
| if(KOKKOS_LINK_OPTIONS) | ||
| set_target_properties(gtest PROPERTIES LINK_FLAGS ${KOKKOS_LINK_OPTIONS}) | ||
| endif() |
There was a problem hiding this comment.
TBH I am not sure we need these.
Signed-off-by: Damien L-G <[email protected]>
f464f6d to
efdaeda
Compare
Signed-off-by: Damien L-G <[email protected]>
Signed-off-by: Damien L-G <[email protected]>
…edness Signed-off-by: Damien L-G <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Water-down version of #8593, deferring the updating our gtest to something more recent, and keeping the fireworks for the next PR.