Minimal changes to support NVCC with GNU 10 as host #8603
+11
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two issues: cmake tries to use -std=c++2a which nvcc doesn't support. No-unique-address doesn't fully work apparently. Signed-off-by: Christian Trott <[email protected]>
|
Alternatively we may wanna just prohibit using GCC 10 as host compiler for NVCC. |
If we can, I would vote for that |
dalg24
reviewed
Oct 24, 2025
Comment on lines
+169
to
+170
| if(CMAKE_CXX_COMPILER_ID STREQUAL GNU) | ||
| if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 11) |
There was a problem hiding this comment.
Please change if(A) if (B) -> if(A AND B)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues: cmake tries to use -std=c++2a which nvcc doesn't support. No-unique-address doesn't fully work apparently.