-
Couldn't load subscription status.
- Fork 66
[Feature/Operator] Configurable node services and users template #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aints feat: TopologySpreadConstraints Signed-off-by: Gene Hynson <[email protected]>
Signed-off-by: Gene Hynson <[email protected]>
Signed-off-by: Gene Hynson <[email protected]>
Signed-off-by: Gene Hynson <[email protected]>
Cherry pick
…thub.com/konpyutaika/nifikop into ft_configurable_template_service_n_users
erdrix
added a commit
that referenced
this pull request
Aug 3, 2022
…ice_n_users [Feature/Operator] Configurable node services and users template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
A limitation with the current implementation is that the user identities and service names can become too long depending on your namespace name and cluster domain. If this string is over 64 bytes, cert manager is unable to create certificates. This is a show stopper issue for us because we cannot change our cluster domains.
This PR allows admin and node user identities to be set to custom values. And it allows service names templates to be overriden.
Four properties added to the NifiCluster spec:
Default behavior is unchanged from the current implementation. None of these new properties are required.
Why?
This PR unblocks teams who have longer cluster domains and want to use a cert-manager integration. Those teams can opt-in to using these four new properties in the NifiCluster spec to shorten the user identities and service names.
I decided to take the implementation path seen here since it did not drift from the current implementation too much. Basically instead of hardcoding the
HeadlessServiceTemplateandNodeControllerTemplate, they can now be overridden by a provided property. TheadminUserIdentityis shared across all the nodes so it can be a static value with any name the user would like. However, thenodeUserIdentityTemplatemust be unique per node therefore the user needs to provide a template so we can populate the node's ID in the user's identity.Additional context
Checklist