Redis config improvements #5
Conversation
| val mono = when (command) { | ||
| RedisCommand.HashSet -> info.commands.hset(info.entryName, key, value) | ||
| RedisCommand.Set -> info.commands.set(key, value) | ||
| } |
There was a problem hiding this comment.
I was under the impression that hashing was always advised over non-hashing. What would be some situations where not using a hash is beneficial?
There was a problem hiding this comment.
Afaik you can't set a TTL for individual hash values but you can with a set
There was a problem hiding this comment.
reading up on it seems like trying to expire a hset would result in the entire has being expired, so you're right there.
If that's the only practical difference though, we shouldn't allow choosing both a command and a TTL, the two decisions depend on eachother.
There was a problem hiding this comment.
maybe something like this?
sealed class RedisCommand {
object HashSet : RedisCommand()
data class Set(val ttl: Long? = null) : RedisCommand()
}| fun <T> Mono<T>.cache(ttl: Duration?): Mono<T> { | ||
| return if (ttl != null) cache(ttl.toJavaDuration()) else this | ||
| } |
There was a problem hiding this comment.
Doesn't this just cache the mono? I was under the impression you need to call something like RedisKeyReactiveCommands#expire to inform redis of a key's TTL.
There was a problem hiding this comment.
Ah. I'm not very familiar with lettuce or rxjava to begin with, I'll switch it over.
hsetorset