Support Kotlin/JS #775
Merged
Support Kotlin/JS #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
- Use bundles for js dependencies - Disable InstantInEpochMillisecondsSerializerTest for now
- Add test-kit - Add samples - Move HttpEngine to common
lukellmann
approved these changes
Apr 4, 2023
|
@DRSchlaubi we should update the PR description to include migration issues/steps (artifact changes, member to extension conversions), then it's good to go |
|
about annotation retention, this is how kxser does it, should we do it like this too? @MustBeDocumented
@Target(AnnotationTarget.PROPERTY, AnnotationTarget.CLASS, AnnotationTarget.TYPE)
//@Retention(AnnotationRetention.RUNTIME) // Runtime is the default retention, also see KT-41082
public annotation class Serializable(
val with: KClass<out KSerializer<*>> = KSerializer::class // Default value indicates that auto-generated serializer is used
)it would mean that it's still available at runtime on jvm at least, i.e. no breaking change |
|
IMO these annotations shouldn't have been on runtime to begin with |
but now they are, so why not keep it that way? |
|
I don't really see the benefit of keeping it |
|
alright, it's fine for me |
lukellmann
added a commit
to lukellmann/kord-extensions
that referenced
this pull request
Apr 5, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to provide Kotlin/JS support for Kord (see #69)
Breaking Changes
dev.kord.common.Locale.asJavaLocale->import dev.kord.common.asJavaLocaledev.kord.core.cache.KordCacheBuilder.lruCache->import dev.kord.core.cache.lruCachedev.kord.rest.builder.message.create.MessageCreateBuilder.addFile->import dev.kord.rest.builder.message.create.addFiledev.kord.rest.builder.message.modify.MessageModifyBuilder.addFile->import dev.kord.rest.builder.message.modify.addFiledev.kord.rest.request.RequestBuilder.file->import dev.kord.rest.request.filejava.util.Localetodev.kord.common.Locale(if you really need to use the Java class, use theasJavaLocaleextension):dev.kord.core.entity.Guild.preferredLocaledev.kord.rest.builder.guild.GuildModifyBuilder.preferredLocaledev.kord.common.annotationand thedev.kord.gateway.PrivilegedIntentannotation now haveBINARYinstead ofRUNTIMEretention. This means they are no longer visible for reflection.-jvmto their artifact IDs forkord-common,kord-rest,kord-gatewayandkord-core.core-voicecapability has been removed, please use thekord-core-voiceartifact instead.