Add support for application emojis #973
Conversation
| keys[Route.EmojiId] = emojiId | ||
| } | ||
|
|
||
| public suspend fun createApplicationEmoji(appId: Snowflake, request: EmojiCreateRequest): DiscordEmoji = |
There was a problem hiding this comment.
Technically application emojis don't have roles, which the Emoji(Create/Modify) builders expose. Discord seems to just ignore it which is fine. Up to you how 1:1 to stick with Discord API.
There was a problem hiding this comment.
I think breaking the API for this is not worth it, so let's just leave this as is
| appId: Snowflake, | ||
| name: String, | ||
| image: Image, | ||
| builder: EmojiCreateBuilder.() -> Unit |
There was a problem hiding this comment.
In this case, since application emojis are just name and image, you can probably get rid of the builder parameter.
| * @param reason the reason showing up in the audit log | ||
| * @throws RequestException if anything went wrong during the request. | ||
| */ | ||
| public abstract suspend fun delete(reason: String? = null) |
There was a problem hiding this comment.
Only guild emojis support deleting with a reason. We can just ignore it in the case of application emojis. Or make CustomEmoji#delete take no reason, and add a GuildEmoji#delete that takes a reason?
Co-authored-by: Marko <[email protected]>
…moji # Conflicts: # core/api/core.api
There was a problem hiding this comment.
Sorry for the late review after merge, can you address my comments in a followup PR @DRSchlaubi?
|
See 2002d0c...eaf5dbe for a cleaner diff of ABI changes. |
No description provided.