Update UIContainerLayouts.kt so graphics{} work better #2166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update UIContainerLayouts.kt so graphics{} work better
|
Thanks! We will need to do the same for the rest, including UIHorizontalStack, etc. |
|
Fixes #2164 |
soywiz
requested changes
Mar 1, 2024
There was a problem hiding this comment.
We need two things:
- Update UIHorizontalStack too.
- Add a test that checks the new behaviour.
My suggestion for the test is the following:
@Test
fun testUIVerticalStack() {
val stack = UIVerticalStack()
val view1 = stack.solidRect(10, 10, Colors.RED)
val view2 = stack.graphics { fill(Colors.RED) { rect(10, 10, 20, 20) } }
val view3 = stack.solidRect(10, 10, Colors.RED)
stack.relayout()
assertEquals("...", "${view1.y.niceStr},${view2.y.niceStr},${view3.y.niceStr}")
}By applying/reverting this change the view3.y should be different. So that will cover that we have fixed the issue.
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2164