is it still a draft?

is it still a draft?

I'd say so, we are discussing it in the other pr :)

lgtm,

should we go away and add a simpler one too to iron out any incompatibilities ?

Also can we not merge this until 6.0.5 has been released, as we should put this only in the 6.1.0 release.

Sounds good re waiting 6.1.0, in that case, would you rather have all the code changes in this pr, so to avoid pr overload ?

Your call - happy for one big one if that saves you sequencing headaches.

Should we add some tests around beforeEach, beforeAny, beforeAll and how they now interact with withXXX ?

I wonder if there's any code to be saved by parameterizing them like we did for test config?
So that withContexts delegates to a withContainerDataTest method that just takes a type parameter for the concrete type it delegates to (similar to your original idea, but means that anyone can extend their own spec style easily if needed). I would only consider doing this if you think it saves you some lines of code overall.

should we go away and add a simpler one too to iron out any incompatibilities ?

stringSpec added to this PR with withTests

Should we add some tests around beforeEach, beforeAny, beforeAll and how they now interact with withXXX ?

I have added some tests for this, it's particularly visible that beforeEach like before counts only before every Container level test and beforeAny before any test, whether Container or Test scopes.

I wonder if there's any code to be saved by parameterizing them like we did for test config?

I don't think we can get any gainings by parameterizing this at this level, as in, I can parameterize it but the DSL will still need to be repeated for every spec, if anything it might add more code into the mix.

Ok cool. I wonder if we shouldn't even bother with StringSpec, kinda seems pointless to mix up plain strings with function calls. Same for free spec? Thoughts ?

Ok cool. I wonder if we shouldn't even bother with StringSpec, kinda seems pointless to mix up plain strings with function calls. Same for free spec? Thoughts ?

That's fair, I will bring it back to withData, as long as we keep withData alive tho, these are my favourite specs :)

@sksamuel and @AlexCue987 all possible specs are done - please have a look and if we are all happy I can do the docs