Allow offset without limit #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* let the `offset` be specified without a `limit` * let the `limit` be specified without an `offset` * let `offset` and `limit` be specified together via separate routines
* prettify general `limit` routine * improve test coverage
9df842b to
0165c43
Compare
vincentlauvlwj
requested changes
Oct 18, 2020
| is SelectExpression -> expression.copy(offset = offset, limit = limit) | ||
| is UnionExpression -> expression.copy(offset = offset, limit = limit) | ||
| } | ||
| when (expression) { |
There was a problem hiding this comment.
We'd prefer 4-space indent here, but there are 8.
| const val ID_1 = 1 | ||
| const val ID_2 = 2 | ||
| const val ID_3 = 3 | ||
| const val ID_4 = 4 |
There was a problem hiding this comment.
We don't have to define these numbers as constants. It makes no sense. Seems the quality check doesn't ignore the test code?
* add my name to contributors list * fix 8-space indents
|
Could you please mark it with |
|
OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
offsetbe specified without alimitlimitbe specified without anoffsetoffsetandlimitbe specified together via separate routines