Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@pull
Copy link

@pull pull bot commented May 15, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

sh-rp and others added 2 commits May 15, 2025 15:21
* Cleaning up commits

* Column normalization before adding dlt columns, test fixes

* Func for adding dlt columns refactored

* Star handler, column normalizer, schema column matcher, dlt adder

* fix in the match schema with columns

* Redshift dlt id hash func added, star expression handler fixed

* Additional comment in the _normalize_selected_columns func

* aliased column test fixed

* Unnecessary stuff removed, select now left intact, only outer query is processed, test skeleton added

* New test added to check normalization of columns

* casefolder added to normalization, test for mssql fixed

* Test for normalizer, data types test

* sqlite _dlt_id workaround and data contract tests

* Raise on non-select in writer and model builder

* need for reordering detection, star selection disallowed

* Normalizer improvements, test fixes

* Essential tests marked

* Test with insert from two tables

* Essential marks removed

* Monkeypatch replaced with preserve_environ, athena iceberg sql job assertion added

* Model item format tests improved, redshift dlt id now uses load it

* Columns not present in the schema, but not select, added as null only if nullable

* test_simple_model_normalizing with a more extended example

* Necessary tests marked as essential

* Caps fixture improved

* Star select rejection and corresponding test moved and simplified

* Star schema with additional columns now also rejected

* Test setup for query edge cases on duckdb dialect

* Test fixes and additionas, star select rejects t1.*

* Add_dlt_id now disabled by default, config test added, star checking removed from load

---------

Co-authored-by: anuunchin <[email protected]>
@pull pull bot added the ⤵️ pull label May 15, 2025
@pull pull bot merged commit ed951d0 into kp-forks:devel May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants