Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dipankardas011
Copy link
Member

@dipankardas011 dipankardas011 commented Jan 13, 2025

πŸ—’οΈ Changelog

  • addition of the kubebuilder boilerplate

πŸ‹πŸΌ Issues

βœ… Completed Issues

  • Fixes:

πŸ“Ž Related Issues

  • Related to:

πŸš€ Task List

  • the addons is a list and we should only delete the addons which are not already installed and for apply the addons if not before installed thus improving the reliability

πŸ” Review Checklist

  • Code follows project style guidelines
  • Added/updated tests
  • Ran tests locally
  • Updated documentation
  • Checked Contribution Guidelines

πŸ“Έ Screenshots/Recordings

πŸ“Œ Additional Notes


πŸ’‘ PR best practices
  • Keep changes focused and atomic
  • Update tests and documentation
  • Check for conflicts with main branch
  • Respond promptly to review comments
  • Follow project coding standards
  • Make sure you are using pre-commit for that run this command $ pre-commit install

Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first pull request in ksctl. I am excited for the day when your changes get merged.

@dipankardas011 dipankardas011 marked this pull request as ready for review January 23, 2025 03:42
Signed-off-by: Dipankar Das <[email protected]>
@dipankardas011 dipankardas011 merged commit 5f601de into main Jan 24, 2025
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants