Update k8s package to 34.1 #4858
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: atalhens <[email protected]>
sivanantha321
approved these changes
Nov 28, 2025
Member
|
@atalhens Can you rasie the PR against master ? |
Member
|
/hold |
Member
|
@atalhens 0.16 is already out. So we don't do a patch release for 0.15. |
olegk-runai
reviewed
Dec 7, 2025
| knative.dev/pkg v0.0.0-20250117084104-c43477f0052b | ||
| knative.dev/serving v0.44.0 | ||
| sigs.k8s.io/controller-runtime v0.19.1 | ||
| sigs.k8s.io/controller-runtime v0.20.4 |
There was a problem hiding this comment.
To support k8s v1.34.1
sigs.k8s.io/controller-runtime should be v0.21.0
Please upgrade it to v0.21.0
Contributor
@sivanantha321 The GIE version in 0.16. was 0.3, which is a version down, and we have seen issues with compatibility when upgrading to 0.16. As GIE upgrade to 1.2 PR is taking some time. Could we get a patch release on 0.15 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates the K8s API version to 34.1, which was previously set to 33.0.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #4857
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note:
Re-running failed tests
/rerun-all- rerun all failed workflows./rerun-workflow <workflow name>- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.