fix: update imports to fix vllm 0.12.0 compatibility #4882
+11
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Context: Updating
vllmin nixpkgs (NixOS/nixpkgs#467418).EDIT: Updated to fix compatibility with vllm 0.15.0.
Latest
vllmrelease 0.12.0 changed the location of a few classes (Embedding*andRerank*).This PR updates the imports in
kserve/protocol/rest/openai/types/__init__.py.Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Before, this PR, running
kserve's test suite had a few failures:Example:
After this change, all tests are successful.
Special notes for your reviewer:
Checklist:
Release note:
Re-running failed tests
/rerun-all- rerun all failed workflows./rerun-workflow <workflow name>- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.