Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@WoH
Copy link
Collaborator

@WoH WoH commented Sep 25, 2019

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues

Closes #483

Previously, the metadata schema generated for arrays assumed a primitive type. That's not always the case (array of arrays, array of nested object literals, etc..).

@simllll
Copy link
Contributor

simllll commented Sep 29, 2019

Hi, thanks for this qick fix! Really impressed ;)
The fix itself looks small, therefore I'm curious if there is any ETA when this will land in master or in a release?

@WoH
Copy link
Collaborator Author

WoH commented Oct 1, 2019

Pinging @dgreene1 @endor

@dgreene1 dgreene1 merged commit 88c5057 into lukeautry:master Oct 2, 2019
@WoH WoH deleted the nol-bugfix branch October 2, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

internal tsoa error: the metadata that was generated should have had nested property schemas since it’s for a nested object,however it did not

3 participants