Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove passing load fallback to itself as an argument #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Remove passing load fallback to itself as an argument #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,17 @@ type Transform = (
fallback: Transform
) => Promisable<{ source: Source }>;

type Load = (
url: string,
context: { format?: Format },
fallback: Load
) => Promisable<{
type LoadResult = Promisable<{
format: Format;
shortCircuit: boolean;
source: Source;
}>;
}>

type Load = (
url: string,
context: { format?: Format },
fallback: (url: string, context: { format?: Format }) => LoadResult
) => LoadResult;

async function toConfig(): Promise<Config> {
let mod = await setup;
Expand Down Expand Up @@ -136,7 +138,7 @@ export const resolve: Resolve = async function (ident, context, fallback) {
export const load: Load = async function (uri, context, fallback) {
// note: inline `getFormat`
let options = await toOptions(uri);
if (options == null) return fallback(uri, context, fallback);
if (options == null) return fallback(uri, context);
let format: Format = options.format === 'cjs' ? 'commonjs' : 'module';

// TODO: decode SAB/U8 correctly
Expand Down