Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
These lines of code may be partially or fully hallucinations, and have not been reviwed by a professional dev.
Summary
Problem
DM rumors were emitted with bare ["p", ""] tags, violating NIP‑17 guidance and forcing receivers to guess which relay to query.
Solution
Look up each participant’s messaging relays before gift-wrapping, stash them in a cache, and rewrite the rumor’s p tags with the first available relay hint. A focused unit test verifies the rewrite.
Benefits
Tradeoffs
Testing
[["p","","wss://…"]].