Fix process.stdin abort when stdin is redirected from a file #1096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a hacky band-aid fix that should be replaced with a more comprehensive solution, see luvit#1094 This only 'fixes' process.stdin, but utils.stdin and pretty-print.stdin will still abort if they are attempted to be read from when stdin is a file. This does fix the example code in luvit#1023, though
zhaozg
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hacky band-aid fix that should be replaced with a more comprehensive solution in the future, see #1094
This only fixes
process.stdin, bututils.stdinandpretty-print.stdinwill still abort if they are attempted to be read from when stdin is a file. This does fix the example code in #1023, though